Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Jinja2 and polarion JUnit flavor to generate XUnit in polarion report plugin #3166

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Use Jinja2 and polarion JUnit flavor to generate XUnit in polarion report plugin #3166

merged 1 commit into from
Sep 24, 2024
+394 −84

Conversation

seberm
Copy link
Collaborator

@seberm seberm commented Aug 26, 2024 •
edited
Loading

Do not edit the default JUnit flavor generated by junit report plugin using an ElementTree, use the predefined Jinja2 Polarion template. This PR also adds the XSD schema for a Polarion XUnit file. The checking against this schema is done dynamically by lxml in the same way as for the default junit flavor.

Related to:

Depends on:

TODOs:

  • testuites properties should be probably part of ResultsContext (as property)
  • Test the actual polarion import (done by @KwisatzHaderach )

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@seberm seberm added step | report Stuff related to the report step plugin | polarion Plugins implementing the Polarion integration plugin | junit The junit report plugin labels Aug 26, 2024
@seberm seberm self-assigned this Aug 26, 2024
@seberm seberm mentioned this pull request Aug 26, 2024
Open
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch 2 times, most recently from cc9e735 to 64b4e8f Compare August 26, 2024 20:50
happz
happz reviewed Aug 27, 2024
View reviewed changes
tmt/steps/report/junit.py Outdated Show resolved Hide resolved
@seberm seberm changed the base branch from main to feature/generate-junit-using-jinja August 27, 2024 11:38
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from 64b4e8f to 96702c5 Compare August 27, 2024 11:47
@seberm seberm force-pushed the feature/generate-junit-using-jinja branch 2 times, most recently from 5d496db to 58689c1 Compare August 28, 2024 10:19
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from 96702c5 to d176291 Compare August 28, 2024 10:29
@seberm seberm force-pushed the feature/generate-junit-using-jinja branch from 58689c1 to 45811c2 Compare August 28, 2024 10:35
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from d176291 to c816734 Compare August 28, 2024 10:52
@seberm seberm mentioned this pull request Aug 28, 2024
Merged
14 tasks
@seberm seberm added the ci | full test Pull request is ready for the full test execution label Aug 28, 2024
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from c816734 to 0ab8423 Compare August 28, 2024 12:09
seberm
seberm commented Aug 28, 2024
View reviewed changes
tmt/steps/report/polarion.py Outdated Show resolved Hide resolved
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from 0ab8423 to 2121ff9 Compare August 28, 2024 13:43
seberm
seberm commented Aug 28, 2024
View reviewed changes
tmt/steps/report/polarion.py Outdated Show resolved Hide resolved
tmt/steps/report/polarion.py Outdated Show resolved Hide resolved
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from 2121ff9 to 018b214 Compare August 28, 2024 15:04
KwisatzHaderach
KwisatzHaderach reviewed Aug 28, 2024
View reviewed changes
tests/report/polarion/test.sh Outdated Show resolved Hide resolved
tests/report/polarion/test.sh Outdated Show resolved Hide resolved
tmt/steps/report/polarion.py Outdated Show resolved Hide resolved
tmt/steps/report/polarion.py Outdated Show resolved Hide resolved
tmt/steps/report/polarion.py Outdated Show resolved Hide resolved
tmt/steps/report/polarion.py Outdated Show resolved Hide resolved
tmt/steps/report/polarion.py Outdated Show resolved Hide resolved
tmt/steps/report/polarion.py Outdated Show resolved Hide resolved
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from 018b214 to 0702405 Compare August 28, 2024 17:06
@seberm seberm marked this pull request as ready for review August 28, 2024 17:34
@seberm seberm force-pushed the feature/generate-junit-using-jinja branch from 45811c2 to 01e3e92 Compare August 28, 2024 18:22
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from ef55cc7 to d14e2bb Compare September 10, 2024 08:40
@happz happz force-pushed the feature/generate-junit-using-jinja branch from e613189 to d8c650a Compare September 10, 2024 09:05
KwisatzHaderach
KwisatzHaderach approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@KwisatzHaderach KwisatzHaderach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, export to polarion is working fine for me with an easy/small plan

@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from d14e2bb to a42179a Compare September 10, 2024 09:27
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from a42179a to 7f8d377 Compare September 10, 2024 14:11
@seberm seberm force-pushed the feature/generate-junit-using-jinja branch from d8c650a to 49a0604 Compare September 11, 2024 09:24
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from 7f8d377 to bd76c53 Compare September 11, 2024 09:31
@seberm seberm force-pushed the feature/generate-junit-using-jinja branch from 49a0604 to 597e000 Compare September 12, 2024 11:32
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from bd76c53 to 163f93f Compare September 12, 2024 11:33
@happz happz force-pushed the feature/generate-junit-using-jinja branch from 597e000 to 38c9d87 Compare September 12, 2024 13:01
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from 163f93f to ec50703 Compare September 13, 2024 09:52
Base automatically changed from feature/generate-junit-using-jinja to main September 13, 2024 16:29
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from ec50703 to 3075f79 Compare September 16, 2024 08:36
@seberm
Copy link
Collaborator Author

seberm commented Sep 17, 2024

/packit test

@seberm
Copy link
Collaborator Author

seberm commented Sep 17, 2024

/packit build

@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from 3075f79 to 2d72ccd Compare September 17, 2024 08:40
happz
happz reviewed Sep 18, 2024
View reviewed changes
tmt/steps/report/polarion.py Outdated Show resolved Hide resolved
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch 2 times, most recently from cba28eb to a5be8c1 Compare September 18, 2024 09:44
@seberm seberm requested a review from happz September 18, 2024 18:46
@seberm seberm force-pushed the feature/use-jinja-in-polarion-plugin branch from a5be8c1 to e6ac533 Compare September 23, 2024 07:44
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Sep 24, 2024
@psss psss force-pushed the feature/use-jinja-in-polarion-plugin branch from e6ac533 to 37740bf Compare September 24, 2024 15:12
@psss psss merged commit bf47358 into main Sep 24, 2024
22 of 23 checks passed
@psss psss deleted the feature/use-jinja-in-polarion-plugin branch September 24, 2024 18:33
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@seberm @The-Mule
Generate XUnit Polarion flavor using JUnit report plugin (teemtee#3166)
d75ab54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinhoyer martinhoyer martinhoyer approved these changes

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@happz happz happz approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@seberm seberm

Labels
ci | full test Pull request is ready for the full test execution plugin | junit The junit report plugin plugin | polarion Plugins implementing the Polarion integration status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. step | report Stuff related to the report step
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.
5 participants
@seberm @happz @KwisatzHaderach @martinhoyer @psss